search

monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

non-unique associations on gene-model pages #1085

Open nlwashington opened 8 years ago

nlwashington commented 8 years ago

on models tab here: http://stage.monarchinitiative.org/gene/NCBIGene:672

we can see non-unique associations, and also associations that ought to disappear as a result of the clique merge. @jnguyenx let's verify the cypher query and golr generation.

jmcmurry commented 8 years ago

This is definitely still an issue. The redundancy is clearest if you download the tsv:

image

There are the coriell IDs and also some blank nodes? @jnguyenx can you investigate?

jmcmurry commented 8 years ago

If it is useful for debugging purposes, using NCBIGene:6622 as a comparison, it seems that we're seeing the duplication only for the coriell/OMIM rows.

kshefchek commented 8 years ago

Is this on solr-dev or production? I fixed this recently but it has likely not made it's way to the production branch, see https://github.com/monarch-initiative/configs/commit/a65910270e349b06c32c0beedd5c91da69ce0b11

jmcmurry commented 8 years ago

@kshefchek It doesn't seem to be fixed on either NCBIGene:6622 dev or prod.

kshefchek commented 8 years ago

I may be misunderstanding, where are the duplicates on dev?

jmcmurry commented 8 years ago

If you look at the screenshot, you'll see:

:genid-nodeid-:person-GM13705 and also Coriell:GM13705

Are these not duplicates just rendered in different ways?

kshefchek commented 8 years ago

This is by design, one is the cell line and one is the patient. I agree it's a bit confusing, I'm not sure we need to display the patient here.

jmcmurry commented 8 years ago

Ah; I see. I agree then, this is unnecessarily confusing to materialize. @mellybelly?

mellybelly commented 8 years ago

well it seems to be a label issue in part. There can be more than one line per patient. We don't want to have patient pages for these, do we? similar to our case pages? seems a bit different but they are also instances. Perhaps just needs to go into some column and have a autogenerated label "patient X with Y disease" or something like that?