search

monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

OMIA source has wrong URL #1116

Open nicolevasilevsky opened 8 years ago

nicolevasilevsky commented 8 years ago

The source on this page has the wrong URL: http://monarchinitiative.org/disease/OMIA:001461-9217

image

It should link out to: http://omia.angis.org.au/OMIA001461/9217/ Not 'http://omia.angis.org.au/001461-9217'

jmcmurry commented 8 years ago

@TomConlin can you look into this to see if it is a curie expansion rules issue?

jmcmurry commented 8 years ago

It would also be awesome if we could nix this whole URL versus URI discrepancy on the overview page once and for all. Where are these discrepant links originating from?

TomConlin commented 8 years ago

The curiemap.yaml has the purl `http://purl.obolibrary.org/obo/OMIA`' as the expansion
https://github.com/monarch-initiative/dipper/blob/master/dipper/curie_map.yaml#L52

the persistent URL base http://purl.obolibrary.org/obo/ has moved to: http://purl.oclc.org/obo/ which has moved to: http://www.berkeleybop.org/ontologies/
which has nothing obvious related to OMIA.

Why are we systematically mapping to purls when direct links are known? Should a direct link display instability before we resort to purls?

jmcmurry commented 8 years ago

Why are we systematically mapping to purls when direct links are known? Should a direct link display instability before we resort to purls?

PURLS (if they are purl.org) are in read-only mode now.

As long as they resolve and are persistent, I'm less bothered about whether we use the direct links or the purls. I'm more concerned with there being a discrepancy without an obvious purpose.