search

monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

Analyze Phenotypes: Clarify that profile input is phenotypes only, not diseases #1296

Open jmcmurry opened 8 years ago

jmcmurry commented 8 years ago

It is not clear what it means or should mean that certain diseases can be selected (eg. Dementia), but that certain others can not be selected (eg. Charcot-Marie...).

Moreover, what the expected behavior is once those diseases are selected is also not clear.

Parking this here for discussion

jmcmurry commented 8 years ago

Just realized that here Dementia is both a disease and a phenotype. As they are both HP terms, it was confusing to me. Not sure how to make this more apparent. Changing the title of the issue accordingly.

jmcmurry commented 8 years ago

Results like this make it especially confusing. This looks like dementia disease versus dementia phenotype when in fact it is dementia phenotype in two different taxa.

screen shot 2016-07-11 at 11 10 32 am
harryhoch commented 8 years ago

I think his might be an ontology issue. At one point, there had been no call that would let us easily restrict the search to (say) hpo vs. something else .Is this no still the case?

jmcmurry commented 8 years ago

The former is HPO, the latter is NBO (eg. Neuro Behavior Ontology, used in ZFIN). I think these are legitimately different results. Will be sorted out once we have taxon options available.

drseb commented 8 years ago

I am not sure what you are trying to achieve, but

Sent from my mobile - hence the brevity and misbakes

On 11.07.2016, at 21:18, Julie McMurry notifications@github.com wrote:

The former is HPO, the latter is NBO (eg. Neuro Behavior Ontology, used in ZFIN). I think these are legitimately different results. Will be sorted out once we have taxon options available.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jmcmurry commented 8 years ago
  • pretty sure users also want to enter a "disease" such as alzheimer, instead of entering every symptom of alzheimer

Agreed, this is functionality I described in other tickets (https://github.com/monarch-initiative/monarch-app/issues/1250 and others). However, this is what we have presently, so worth making sure that the users expectations are appropriately managed.

See also https://github.com/monarch-initiative/monarch-app/issues/994