search

monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

Evidence type missing #1344

Open jmcmurry opened 8 years ago

jmcmurry commented 8 years ago

@mbrush do you know why evidence type is missing from the display; is it because it isn't in the graph? Do we have enough ECO codes to cover our needs for this?

screen shot 2016-08-24 at 1 53 33 pm
kshefchek commented 8 years ago

I don't see it in the RDF model. Clinvar is an odd source since we've implemented the SEPIO model, but this won't be captured and indexed in the golr loader yet. @TomConlin may know what's going on.

TomConlin commented 8 years ago

In a non exportable comment in the clinvar cmap @mbrush wrote:


IRI type:  CONSTANT for now. All instances of ECO:0000000. 
Since ClinVar does not use ECO codes, our first pass can just use the most generaic 'evidence' root.  But in our next iteration, we should come up with rules for assigning a more specific evidence code based on metadtaa provided (e.g. the study type).

we do see 162,698 ECO:0000000 in the ClinVar triples

kshefchek commented 8 years ago

Unless we hang these off the association node directly, it won't be indexed in golr. Regardless we likely do not want ECO:000000 showing up anyways. Seems like a non-issue until we implement this in dipper.