Make analyze phenotypes a widget

monarch-initiative / monarch-legacy

Monarch web application and API

BSD 3-Clause "New" or "Revised" License

42 stars 37 forks source link

Make analyze phenotypes a widget #486

Open mellybelly opened 10 years ago

mellybelly commented 10 years ago

It would be great if we could widgetize this for use in other systems. We also need a name for this tool.

harryhoch commented 9 years ago

assume this refers to the broader functionality of submitting arbitrary phenotypes to simsearch/phenogrid? If so, this is probably more wishlist than vestigal.

jmcmurry commented 9 years ago

hmm. looks like there's a gihub bug.

jmcmurry added vestigial and removed vestigial labels 8 days ago

The vestigial label is still showing up even though it was removed immediately. We need to think about which parts are actually valuable to widgetize.

cmungall commented 9 years ago

How about splitting like this:

phenotype/patient/organism profile builder widget.
owlsim widget

2 would wrap 1 plus phenogrid.

1 would look just like our existing profile builder (ie autocomplete plus a persistent collection), but would be extensible:

allow negation, per phenotype
allow frequency, severity, per phenotype
age of onset, per phenotype
Addition of other patient/organism attributes: sex, age, diagnosis, ...
Addition or linkage to genotypic information
Addition of pedigree information

This widget could be resued in an owlsim app (e.g. 2), an exomiser app, a tool to allow export of a json phenopacket for submission to journals, pasting into a facebook page, ...

There is some overlap with the phenotua forms interface but may be simplest to keep this distinct for now. cc @kltm

kltm commented 9 years ago

Just looking at that list, if a generalized query/boolean "builder" widget could be abstracted out of there, it would probably find a lot of use elsewhere.

harryhoch commented 9 years ago

@cmungall, it sounds like you're basically suggesting a generalized end-user phenotype annotation tool. +1 for the need, but doing it completely would not be a trivial project. Can we find the resources?

cmungall commented 9 years ago

We are doing it I'm just pointing out the commonalities to see where the most appropriate reuse points are

On 17 Oct 2015, at 10:45, Harry Hochheiser wrote:

@cmungall, it sounds like you're basically suggesting a generalized end-user phenotype annotation tool. +1 for the need, but doing it completely would not be a trivial project. Can we find the resources?

Reply to this email directly or view it on GitHub: https://github.com/monarch-initiative/monarch-app/issues/486#issuecomment-148937605

harryhoch commented 9 years ago

@cmungall great. glad to hear it. should we discuss these design issues on a Thursday call?