monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

Ordering of phenotype frequencies not documented #523

Closed KimJBaran closed 6 years ago

KimJBaran commented 10 years ago

The ordering of frequency information regarding phenotypes is not clear. It might be documented somewhere, but it is not clear where.

For example, how are "hallmark", "typical", "frequent" and "occasional" related to each other? Can I assume the following in descending order?

  1. hallmark
  2. typical
  3. frequent
  4. occasional
nlwashington commented 9 years ago

apologies for the lack of documentation. you can find the descriptions of HPO frequency labels (along with their approximate mapping to %) here:

http://www.human-phenotype-ontology.org/contao/index.php/annotation-guide.html

we will look at adding documentation about these, and appropriate sort order to the column (being numerical, rather than alphabetic).

nlwashington commented 9 years ago

@pnrobinson will the frequency information ever be converted to classes (and where would such classes exist)?

mellybelly commented 9 years ago

Yes we discussed as part of the phenotype data exchange format. We should fix this. I will create a ticket in the phenotype ontology project: https://code.google.com/p/phenotype-ontologies/issues/detail?id=55

jmcmurry commented 8 years ago

relevant for renewal

pnrobinson commented 8 years ago

I am not sure I see the action item here, but I think the questions is whether the annotation frequencies documented here (http://human-phenotype-ontology.github.io/documentation.html#annot) should be made into full-fledged classes? Another important issue is that Orphanet has a smaller list of categories, and we have been considering either adopting them or meeting in the middle. I think in retrospect that our list has too many categories, and in actuality, these categories have been rarely used by us or by other users of HPO.

drseb commented 8 years ago

I think this is a valid candidate for a new sub-ontology. Should we do this?

pnrobinson commented 8 years ago

Well, I think it is OK, but remember we were speaking with Ana about agreeing to use the same frequency categories, and we still need to make a decision there. So let's talk about this before making anything public!

mellybelly commented 8 years ago

what is the reason to not use a data property?

drseb commented 8 years ago

but remember we were speaking with Ana about agreeing to use the same frequency categories, and we still need to make a decision there

I remember that, but I think we already agreed upon a new standard

what is the reason to not use a data property?

why do we not use a data property for the age of onset then?

jmcmurry commented 8 years ago

I don't have a particularly strong feeling about which way to go with this, but we should settle on a plan and either flesh it out or close this ticket if it has been OBE.

pnrobinson commented 8 years ago

Seb, should we confirm with Ana first that we will coordinate on one system of frequencies? And document this on the HPO website?

drseb commented 7 years ago

hi. we have now one vocabulary for frequencies, that has been developed together with Orphanet. See e.g. http://compbio.charite.de/hpoweb/showterm?id=HP:0040279

kshefchek commented 6 years ago

Re-opening since these classes are not in the app on the disease to phenotype tables.

kshefchek commented 6 years ago

these were added back to our tables with #1496