search

monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

Some disease pages for DO IDs returning 502 #627

Open kshefchek opened 9 years ago

kshefchek commented 9 years ago

For example: http://tartini.crbs.ucsd.edu/disease/DOID_630

kshefchek commented 9 years ago

I think these pages are timing out and it looks like my code that uniquifies the disease gene associations based on disease equivalency is part of the problem. For now maybe we could disable this on gene sets larger than a certain size. I probably should refactor this code as well.

kshefchek commented 9 years ago

This page taking 15 minutes+ to load when running locally, so I think this will have to be revisited after the major refactor.

cmungall commented 9 years ago

DOID_630 is 'genetic disease'. It doesn't make sense to show any of our tabs, other than classification.

Suggest temporary fix:

## check for 'genetic disease' or 'disease'
if (id == 'DOID:630' || id == 'DOID:4') {
   ...
}

for these two, do not show any tab (or show 0), do not execute the queries.

I'll take care of this

jmcmurry commented 8 years ago

It looks like the neighborhood view is taking several minutes load, but other tabs are taking about a minute which isn't too bad. Is this adequate? If not, what are the blockers?