search

monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

Pages exist for deprecated ontology concepts #643

Open twhetzel opened 9 years ago

twhetzel commented 9 years ago

I was checking the Monarch UI app behavior for deprecated terms and checked a page manually for a deprecated term in DOID and found that a page does exist for this concept: http://monarchinitiative.org/disease/DOID:5898

NOTE: There is a term in DOID with the same label that is not deprecated,
http://monarchinitiative.org/disease/DOID:898

nlwashington commented 9 years ago

What is the desired behavior here? I imagine it could either redirect to the replacement term, or it would simply list that it is deprecated and provide a link to the suggested page, if available.

Of course, if there is >1 term (as in a split) then it should probably indicate it is deprecated, and list the terms for consideration.

What would we do if it's just been deprecated and no replacement is suggested? probably just list that much.

selewis commented 9 years ago

I was just dealing with exactly this situation in PAINT/touchup the other day. What I did (after discussion) was this.

If term exists and is obsolete, but there is a replacement term (or terms, this happens too) then it is automatically substituted in (with notice to user)

If term exists and is obsolete, but there is no replacement term, then post a notice to the user

If the term does not exist then determine whether or not it appears as an 'alt-id' type synonym. If yes then carry out the replacement. If not, then pull the fire alarm because this is very bad.

-S

On Wed, Jan 21, 2015 at 1:56 PM, Nicole Washington <notifications@github.com

wrote:

What is the desired behavior here? I imagine it could either redirect to the replacement term, or it would simply list that it is deprecated and provide a link to the suggested page, if available.

Of course, if there is >1 term (as in a split) then it should probably indicate it is deprecated, and list the terms for consideration.

What would we do if it's just been deprecated and no replacement is suggested? probably just list that much.

— Reply to this email directly or view it on GitHub https://github.com/monarch-initiative/monarch-app/issues/643#issuecomment-70929756 .

mellybelly commented 9 years ago

@cmungall should comment but I agree with above:

I think I would want a redirect to the replacement term with an indication there that that was why the person landed there.

for consider annot props list the terms for consideration.

If no replacement -just list that much.