Open nlwashington opened 9 years ago
This could be useful on other object categories, such as genotype and disease too
On 8 Jun 2015, at 5:40, Nicole Washington wrote:
it would be convenient if there was a gene column (as an attribute of the variant) added to the variant tables. it would help with interpretation. @ccondit, this will require additional fields in the golr schema.
Reply to this email directly or view it on GitHub: https://github.com/monarch-initiative/monarch-app/issues/746
@cmungall should we really have genes here for disease? can you clarify what you want populated in that case?
After discussing this with @nlwashington here's what needs to happen:
subject_gene
, subject_chromosome
, object_gene
, object_chromosome
and subject_gene_label
, subject_chromosome_label
, object_gene_label
, and object_chromosome_label
to the oban model as Golr closures.gene
, variant
, or genotype
should add a gene and / or phenotype when available.This is loaded on geoffrey
Thanks @ccondit! Will update the oban config and then add these to the variant pages.
some kinks to be worked out, assigning back to Chris.
Does this seem resolved with the latest Golr load?
This doesn't appear fixed yet (on non-Gene pages).
On gene pages, all looks to be in order.
@nlwashington do you anticipate that this will be fixed with next golr load?
i think the data is ready to go; just has to be added to the app code to leverage it in a new column of those tabs.
Great! Sounds easy enough. What is your preferred column header in this (non-gene-page) context? Also do you want just the gene, or also the relationship (eg. is allele of).
I'm not able to get this information from the current golr instances. There may be an issue at load time.
We have this in the latest golr load on persei, I suggest we deploy this first, then we can add the column to the config
I think https://github.com/SciGraph/golr-loader/commit/c88693a2d7ec64a20011f215292d098fddfd7f68 should fix it, but let's leave open to make sure.
ok; will flag with 'revisit in testing'.
it would be convenient if there was a gene column (as an attribute of the variant) added to the variant tables. it would help with interpretation. @ccondit, this will require additional fields in the golr schema.