monarch-initiative / monarch-legacy

Monarch web application and API
BSD 3-Clause "New" or "Revised" License
42 stars 37 forks source link

In site search, taxon column should not be blank for phenotypes and diseases (models?) #991

Open jmcmurry opened 9 years ago

jmcmurry commented 9 years ago

Related to https://github.com/monarch-initiative/monarch-app/issues/983 Currently taxon is only fetched for genes. Therefore it looks weird to see the column blank for disease / phenotype searches as taxon is relevant. See for example http://beta.monarchinitiative.org/search/kallmann screen shot 2015-10-08 at 17 15 42

As a strawman, consider the following:

In either case, I would also like to see an additional column for either the source or the CURIE to help distinguish and contextualize results.

cmungall commented 9 years ago

Another option is simply to rename the column as something neutral, like 'context'

Looking ahead, we want any node in the graph to be findable here. Currently only the ontology-graph is searched, as there are issues doing full text indexing on the complete graph ( @jnguyenx - is there a SG ticket open?). Different categories of node will have different relevant neighbor nodes.

jmcmurry commented 9 years ago

ok, sounds good; let's perhaps:

image

Also Kudos to Github, it was a stab in the dark to paste this text from Excel into an issue, but it was immediately and automatically converted to png. Aaa-mazing.

jnguyenx commented 9 years ago

@cmungall here are the tickets in SciGraph for text search https://github.com/SciGraph/SciGraph/labels/vocabulary%20overhaul

jmcmurry commented 9 years ago

ps. Ultimately the taxon column issue will rear its head any time we have a multi-category table. Eg. http://monarchinitiative.org/labs/golr/NCBIGene:6469