Closed glass-ships closed 1 year ago
In the meantime I've manually grabbed the files we use and added them to the mappings/
directory,
if preferred we can figure out the makefile/boomer/etc. stuff out later
Looks good to me so far. The GH action fail may be fixed by adding version: 1.3.2
under with:
in the workflow test.yaml
- name: Install Poetry
uses: snok/install-poetry@v1
with:
virtualenvs-create: true
virtualenvs-in-project: true
version: 1.3.2
The main thing holding it back as far as i can tell is the missing mapping_justification
column in what appears to be every file, but it's not clear to me where/how to fix this with how the repository works.
any suggestions?
Is it the same issue that you had in the koza
PR?
@glass-ships can you spend some time to go through: https://mapping-commons.github.io/sssom/tutorial/
This should give you all the answers for how to construct a valid SSSOM file.
mapping_justification
needs to be added to every SSSOM table!
@hrshdhgd yes it seems so
@matentzn i'm familiar with the fact that the mapping_justification
column needs to exist in every sssom file.
as i've mentioned, my confusion comes from the way this repository works, the boomer stuff, the templates, the various files. i don't understand where this column needs to be added within the context of this repository.
if getting clear instructions or feedback isn't feasible, i'd recommend @kevinschaper and myself work on a new version of this repository which is more streamlined, clear, and well documented
Got it. Ok! We can meet together so I can explain to you. Wednesday 27th September?
sure, that day works for me. we can coordinate on slack to pick a time if need be
Closing in favor of #25
Attempts to resolve #23 (see issue for relevant errors)
mapping_set_id
(not sure what this should be)mapping_justification
column in apparently every file