Closed cmungall closed 8 years ago
I assume you mean WebPhenote in top left.
I am currently filling the selection table with data from the Minerva response enumerating the GitHub models directory. It's a hack where I just fill the selection table with data gathered from the Minerva response intended to fill the Danger Zone table. A better way is to separate the model from the view code so that we can just pass in a model object (in the MVC sense) and have the selection table render itself. I started down this road but backed out.
Currently deploying from my fork, but want to go home to Noctua master.
I think that establishing a WebPhenote-mode configuration flag (e.g., in the startup.yaml) would be a quick way to move forward and allow two presentations (GO and WebPhenote) of the same codebase. I'm already using such a flag (hardcoded) to determine whether to fill the selection table with GOLR data or GitHub data. By default, this is going to be my approach so that I can get my code integrated back to the Noctua repo. I have some other fixes that would be good for Noctua.
Any suggestions on what such a startup.yaml flag would look like? Options:
WEBPHENOTE=1
(0 is the default, implying GO theme)THEME=webphenote
(with THEME=go
the default)Preferred would be
NOCTUA_CONTEXT=(go|monarch|<string>)
I'm adding a logo for Monarch, I can add one for GO Noctua, or we can continue without a logo with some conditional code. Here's the logo I was thinking of adding as the navbar-brand logo in the upper left corner: https://s3.amazonaws.com/go-public/image/go-logo-icon.png
@DoctorBud yes, that's the correct GO logo right now. If it's going up top there, probably no reason not to add them at the same time.
@kltm @cmungall @hdietze I have a big PR here: https://github.com/geneontology/noctua/pull/307 and a supporting PR here: https://github.com/berkeleybop/bbop-client-barista/pull/1
I need one other human to try to build and run Noctua in GO mode to make sure I didn't break anything. The startup.yaml
file will need to have a NOCTUA_CONTEXT=go
line added (WebPhenote uses NOCTUA_CONTEXT=monarch
).
Not sure whether new app vs yaml vs fork is the best long term/ short term fix, this is just to give a rough idea