monarch-initiative / monarch-phenote

stub for monarch phenote
4 stars 3 forks source link

Oddities in folding in graph display #43

Open cmungall opened 7 years ago

cmungall commented 7 years ago

See: http://create.monarchinitiative.org/editor/graph/gomodel:5797c67200000016

The underlying edge is

[a ParkinsonDisease] --has_part--> [a Tremor]

When folding a relationship, the directionality must be preserved. ie this should be shown as:

PD 
has_part(Tremor)

however, it is inverting it:

Tremor
has_part(PD)

it is never semantically correct to do this, unless R is replaced with InverseOf(R). This is the same as translating the base graph to the equivalent:

[a Tremor] --part_of--> [a ParkinsonDisease]

based on the inverse properties declaration

(although a generic graph editor issue this is only affecting monarch so far)

kltm commented 7 years ago

As I mentioned, this smells a lot like a fold configuration issue; I've, so far, been unable to create anything like this in GO Noctua. Semantics have no part if there is a raw override in the configuration of the folding order. Where is the startup.yaml for Monarch being kept? I'd like to first check the settings of COLLAPSIBLE_REVERSE_RELATIONS.

cmungall commented 7 years ago

COLLAPSIBLE_REVERSE_RELATIONS sounds like the kind of configuration parameter that should be eliminated. I believe this was introduced for protein complexes, but the original implementation was incorrect. Remember this one? https://github.com/geneontology/noctua/issues/265

On 27 Jul 2016, at 0:51, kltm wrote:

As I mentioned, this smells a lot like a fold configuration issue; I've, so far, been unable to create anything like this in GO Noctua. Semantics have no part if there is a raw override in the configuration of the folding order. Where is the startup.yaml for Monarch being kept? I'd like to first check the settings of COLLAPSIBLE_REVERSE_RELATIONS.


You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/monarch-initiative/monarch-phenote/issues/43#issuecomment-235512493

kltm commented 7 years ago

Either way, we need to see the current configuration to make sure that this is what's going on.