monarch-initiative / monarch-trapi-kp

NCATS Translator ARA TRAPI wrapper for the Monarch Initiative system
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Action list from January 2024 #1

Open RichardBruskiewich opened 10 months ago

RichardBruskiewich commented 10 months ago
    • [ ] Identify or create a more specific predicate for the SemSimian output knowledge edges
      • [x] For now use biolink:similar_to
      • [ ] Review better options for this, e.g. biolink:manifestation_of or ???
    • [x] Review and implement the (Vlado et al) UUID identification strategy for description of the UUID generation of subject or object nodes of an edge/association based on a set of terms members of a phenotypic profile.
      • [x] Review interpretation and implementation of the is_set flag in the context of the multi-CURIE use case.
      • [x] Generate and apply UUID nodes for knowledge graph and result (phenotypic) profile subsets of terms
    • [x] Specify a complete sample TRAPI Response JSON to guide further complete TRAPI /query implementation _(Matt, Sierra)
      • [x] Add the 'auxiliary_graphs' JSON block to the TRAPI response
      • [x] Build and return TRAPI auxiliary graphs containing detailed similarity assertions with scores from SemSimian
      • [ ] Review the need to somehow report (unduplicated?) the symmetrical subject_best_matches in addition to the object_bestmatches already returned.
    • [x] Use infores:semsimian-kp as the primary_knowledge_source (How do we account for the original knowledge assertions, e.g. from HPO or MONDO or ???)
    • [x] By default, only return “the top 5” most similar pairwise comparisons to limit the size of the auxiliary graph block, however, incorporate some kind of TRAPI QueryGraph parameter to signal expansion of results to a larger number of hits.
    • [ ] Convert vanilla Docker to Docker Compose management of the containers.
    • [x] Fix server Open Telemetry code - the latest OT code modules appear to have removed the trace.get_tracer_provider().add_span_processor method
    • [ ] If desired, implement the 'common' API endpoints - i.e. get_node() and get_single_hops()
    • [ ] Review whether or not a new specific "multi-curie' workflow operation needs to be defined for this use case
    • [x] Decide on official name of this system including KP versus ARA nature
    • [ ] Review meeting minutes for any implementation or feedback loose ends.
    • [ ] Review latest Plater code for any additional changes worth incorporating
RichardBruskiewich commented 10 months ago

@mbrush and @sierra-moxon, a super quick scan of the Biolink Model dredged up the following predicate:

  manifestation of:
    is_a: related to at instance level
    description: >-
      that part of a phenomenon which is directly observable or
      visibly expressed, or which gives evidence to the underlying
      process; used in SemMedDB for linking things like dysfunctions
      and processes to some disease or syndrome
    range: disease

which almost feels like an appropriate predicate, even though it is not taken as 'similarity' per say.