monarch-initiative / monarch-ui

The previous version of the Monarch Initiative website
https://previous.monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
17 stars 29 forks source link

Fix label for identifiers from GARD #243

Closed monicacecilia closed 5 years ago

monicacecilia commented 5 years ago

When exploring the results for the term 'polysyndactily,' found that the identifier for an equivalent ID from GARD is incorrectly labeled as OBO:GARD_0001616, where it should be GARD:0001616

Screen Shot 2019-05-13 at 9 22 29 AM

@deepakunni3 - could you please add more detail here?

kshefchek commented 5 years ago

The OBO:XYZ_123 ids are coming from biolink, this pages calls:

https://api-dev.monarchinitiative.org/api/graph/edges/from/MONDO:0008272?fetch_objects=false&get_association_counts=false&exclude_automatic_assertions=true&rows=100

deepakunni3 commented 5 years ago

It looks like thats what is being fetched from SciGraph.

This equivalent ID is coming directly from MONDO.

An excerpt from mondo.owl,

    <owl:Class rdf:about="http://purl.obolibrary.org/obo/GARD_0001616">
        <owl:equivalentClass rdf:resource="http://purl.obolibrary.org/obo/MONDO_0008272"/>
    </owl:Class>

the IRI gets contracted to OBO:GARD_0001616.

@kshefchek @cmungall

kshefchek commented 5 years ago

That makes sense, I now see we have this issue on the legacy app as well, https://monarchinitiative.org/disease/MONDO%3A0008272

Adding GARD and COHD to the curie_map in the dipper repo should fix this.

monicacecilia commented 5 years ago

Hi @cmungall and @pnrobinson: see also this issue.

pnrobinson commented 5 years ago

@monicacecilia We need a decision as to how to address this. It seems to me this is probably a backend issue that should go to the biolink tracker?

monicacecilia commented 5 years ago

@pnrobinson - I've transferred the issue to the dipper repo. Above, from @kshefchek: Adding GARD and COHD to the curie_map in the dipper repo should fix this.

kshefchek commented 5 years ago

This is fixed with https://github.com/monarch-initiative/dipper/pull/788

It should be visible once disease pages are fixed on beta, but for now you can see the fix in the api-dev url above.