search

monarch-initiative / monarch-ui

The previous version of the Monarch Initiative website
https://previous.monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
17 stars 28 forks source link

Broken ensembl button on ensembl gene pages #376

Closed kshefchek closed 3 years ago

kshefchek commented 3 years ago

For example on https://monarchinitiative.org/gene/ENSEMBL:ENSG00000213121 the first button does nothing and the second links to Ensembl. Note also the missing label for these, but that will need to be fixed upstream, it looks like ncRNA that do not get merged with HGNC don't have labels.

jen-martin commented 3 years ago

Does PR #403 solve the problem, or is there more to do on this ticket?

jen-martin commented 3 years ago

@kshefchek: I'm not seeing the missing label part of your comment. Can you clarify?

kshefchek commented 3 years ago

This is for the title bar where it says: "ENSEMBL:ENSG00000213121 ENSEMBL:ENSG00000213121"

Will take a look at #403 then I think this can be closed!

monicacecilia commented 3 years ago

(eek. I went trigger happy and merged #403 before I read you also wanted to have a look, @kshefchek. may I kindly ask you to please review and revert if you don't think it satisfies this ticket? Thank you, and sorry. :bowtie: )

monicacecilia commented 3 years ago

:bowtie: