monarch-initiative / monarch-ui

The previous version of the Monarch Initiative website
https://previous.monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
17 stars 28 forks source link

need to fix google structured data #83

Closed nathandunn closed 1 month ago

nathandunn commented 5 years ago

78 is not yet fixed.

Let's fix #81 first to make it easier to test.

See: https://search.google.com/structured-data/testing-tool/u/0/#url=http%3A%2F%2Fbeta.monarchinitiative.org%2Fgene%2FZFIN%3AZDB-GENE-001103-2

The JSONLD script is there, but its not getting picked up. Possible because its a JSON Array.

The snippet provided is actually fine:

[
  {
    "@context": "http://schema.org",
    "@type": "Organization",
    "url": "https://monarchinitiative.org",
    "email": "info@monarchinitiative.org"
  },
  {
    "@context": "http://schema.org",
    "@type": "WebSite",
    "url": "https://monarchinitiative.org",
    "potentialAction": {
      "@type": "SearchAction",
      "target": "https://monarchiniative.org/search/{term}",
      "query-input": "required name=term"
    }
  }
]

Note @cmungall / @kltm . . I think just adding it with a simple tag doesn't quite work.

Not sure what secret sauce that google structured data needs from vuejs, or maybe google is just grumpy today.

Not high priority, so can recheck later.

monicacecilia commented 5 years ago

Hi @nathandunn, should failed attempts from #78 and #81 close this ticket, then?

nathandunn commented 5 years ago

No, they are fine. This should still go in, I just don't know if its high priority for @cmungall or not and it would probably go on @kshefchek 's plate at this point anyway.

monicacecilia commented 5 years ago

Thanks. I don't think it is high priority for first release, but something to keep in the radar.