search

monarch-initiative / monarch-ui

The previous version of the Monarch Initiative website
https://previous.monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
17 stars 29 forks source link

Minor improvements for term pages #96

Closed cmungall closed 5 years ago

cmungall commented 5 years ago

Some can be slow to load. Would be good to diagnose so we can come up with a plan, e.g.

http://beta.monarchinitiative.org/phenotype/HP:0010831

(this may have been a temporary issue, but it would be good to get an idea of load time of different pages under different loads)

We calculate both |association| and |gene|, but we show in different places (former once you click on the tab, latter on the tab itself) which can look a bit odd? I'm not sure, get a second opinion on this. http://beta.monarchinitiative.org/phenotype/HP:0010831#gene

image

kshefchek commented 5 years ago

I think both of these issues (performance, counts) come from upstream components - solr, ontobio, biolink. I think it makes sense to get rid of distinct counts in favor of globally using association counts. The exception being special stats endpoints where we only was unique counts of entities of type \<T>. Long standing ticket - https://github.com/monarch-initiative/monarch-app/issues/1263

I think the action item here is to move and task over in biolink.

monicacecilia commented 5 years ago

@deepakunni3 - hi :bowtie: This may be another issue to pick up at biolink. May I kindly ask you to please have a look and update as necessary when you get the chace? Thank you!

jmcmurry commented 5 years ago

In latest PR by @iimpulse responsiveness seems to be better in my hands. Still could improve, but thought I would mention.

monicacecilia commented 5 years ago

I don't know if @deepakunni3 has had a chance to look a the 'counts' issue yet. I don't have the powers to transfer this issue to the BioLink repo from here, so I created a new ticket there. Closing here in favour of this ticket on the biolink/biolink-api repo.

monicacecilia commented 5 years ago

Also added https://github.com/biolink/biolink-api/issues/308 to New UI v1.0 Project Board.