Open joeflack4 opened 4 months ago
Oh, also @hrshdhgd I don't know if this will happen again in the future, but I have been keeping docs/developer/add-new-source.md
updated. Basically when we add a new source, any necessary configuration should go in here. So if you happen to add any new source configuration or change any existing source configuration, please make an update to that file.
I think probably branching logic inside of lexmatch-sssom-compare.py is not the best location for this kind of configuration.
@joeflack4 I agree with your proposals and prefer a.a
at first glance
Overview
I think probably branching logic inside of
lexmatch-sssom-compare.py
is not the best location for this kind of configuration. Thinking maybe moving to:metadata/ONTOLOGY.yml
: My initial thought is add acomponent_filename
field tometadata/ONTOLOGY.yml
. And then we would have lexmatch simply check that, and then pull thebase_prefix_map
. Then we would pullsubject_prefixes
from there, although to do that, we'd have to go with my suggestion of movingsubject_prefixes
frommondo.config.sssom.yml
.lexmatch_config
(.py
,.json
, or.yml
)Additional details
What the configuration currently looks like: