monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Refactor lexmatch source configuration #484

Open joeflack4 opened 4 months ago

joeflack4 commented 4 months ago

Overview

I think probably branching logic inside of lexmatch-sssom-compare.py is not the best location for this kind of configuration. Thinking maybe moving to:

Additional details

What the configuration currently looks like:

ont2 = ont.upper()
if ont == "omim":
    ont2 = "|".join((["OMIM", "OMIMPS"]))
elif ont == "ordo":
    ont2 = "|".join((["ORDO", "Orphanet"]))
elif ont == "icd11foundation":
    ont2 = 'icd11.foundation'
joeflack4 commented 4 months ago

Oh, also @hrshdhgd I don't know if this will happen again in the future, but I have been keeping docs/developer/add-new-source.md updated. Basically when we add a new source, any necessary configuration should go in here. So if you happen to add any new source configuration or change any existing source configuration, please make an update to that file.

matentzn commented 3 months ago

I think probably branching logic inside of lexmatch-sssom-compare.py is not the best location for this kind of configuration.

@joeflack4 I agree with your proposals and prefer a.a at first glance