monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Add the orphanet subset to the Slurp file #527

Closed sabrinatoro closed 6 months ago

sabrinatoro commented 6 months ago

when reviewing the slurp/ordo.tsv, it would be helpful to know whether the orphanet term is in the "grouping disease", "disorder", or "subtype of disease" subset in orphanet. Please add a column in the slurp/ordo.tsv for the orphanet subset. Thank you!

joeflack4 commented 6 months ago

That sounds helpful! I will be happy to help out.

Thoughts for myself about implementation:

matentzn commented 6 months ago

This is already done and is exactly what our https://github.com/monarch-initiative/mondo-ingest/pull/510 is about..

joeflack4 commented 6 months ago

I'm not the user of these outputs, so I can't say how useful it is to have this subset info in reports /ordo-subsets.robot.template.tsv vs in slurp/ordo.tsv as @sabrinatoro is asking. But they are different files each with different information, and have different numbers of rows.

reports /ordo-subsets.robot.template.tsv (9348 rows): mondo_id subset ordo_id mondo_label ordo_label
ID A oboInOwl:inSubset >A oboInOwl:source
slurp/ordo.tsv (13 rows): mondo_id mondo_label xref xref_source original_label definition parents
ID LABEL A oboInOwl:hasDbXref >A oboInOwl:source SPLIT=" A IAO:0000115 SC %
matentzn commented 6 months ago

@joeflack4 you are right, thanks for correcting me. #510 is sync, the request is for migrate and serves multiple purposes:

  1. ORDO sourced diseases immediately have the correct subset (no delay waiting for sync)
  2. The editor knows "aha, this is a group of disorders, maybe I should obsolete it rather than add it".

So forget what I said, and thanks for the correction!

joeflack4 commented 6 months ago

Addressed by: