monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Build 2024-05-20 #530

Closed twhetzel closed 6 months ago

twhetzel commented 6 months ago

Overview

New build.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

twhetzel commented 6 months ago

I ran sh run.sh make build-mondo-ingest, was another make command supposed to be run for this?

matentzn commented 6 months ago

It looks like you ran sh run.sh make build-mondo-ingest but you should run: sh run.sh make build-mondo-ingest -B if you run the whole pipeline. That should probably be mentioned in the docs as well.

joeflack4 commented 6 months ago

Or, can do what I do and clone a copy of the repo and run the build there. I think this should have the same effect as -B, but probably the reason I started doing this is so I could continue development while the build runs in parallel.

twhetzel commented 6 months ago

Thanks, I'll re-run with -B and created a ticket to update the docs.