The goal lexmatch/README.md is confusing and against the typical way that goals in make are normally supposed to work mondo-ingest, in that it only shows 1 target lexmatch/README.md, even though it generates a number of files.
I can see why this was done. We'd have to list 2 output files *_lex.tsv and *_lex_exact.tsv for each source. But then, if someone wanted to run on a single source, and they ran, say, unmapped_icd11foundation_lex.tsv, it would run for ALL sources.
This could be addressed with a refactor to make this goal and the Python file that it call to be in line with how we typically have goals / pipelines set up in mondo-ingest--that is, the target of the goal would be a wildcard, as in slurp/%.tsv, and then to run them all, we'd have separate goal for that, e.g. slurp-all.
Overview
The goal
lexmatch/README.mdis confusing and against the typical way that goals inmakeare normally supposed to workmondo-ingest, in that it only shows 1 targetlexmatch/README.md, even though it generates a number of files.I can see why this was done. We'd have to list 2 output files
*_lex.tsvand*_lex_exact.tsvfor each source. But then, if someone wanted to run on a single source, and they ran, say,unmapped_icd11foundation_lex.tsv, it would run for ALL sources.This could be addressed with a refactor to make this goal and the Python file that it call to be in line with how we typically have goals / pipelines set up in
mondo-ingest--that is, the target of the goal would be a wildcard, as inslurp/%.tsv, and then to run them all, we'd have separate goal for that, e.g.slurp-all.Sub-tasks
makegoal setuplexmatch-sssom-compare.py