monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

HGNC robot template #558

Open joeflack4 opened 3 weeks ago

joeflack4 commented 3 weeks ago

Overview

There is an OMIM release artefact mondo_genes.csv. It needs to be changed into a ROBOT template.

Sub-tasks

I. omim @joeflack4

II. mondo-ingest @joeflack4

III. mondo (@matentzn & @twhetzel)

Sub-task details

omim 1. Set a ROBOT subheader

mondo_id hgnc_id omim_disease_xref source_code omim_gene
ID SC 'has germline mutation in' some % >A oboInOwl:source >A oboInOwl:source
http://purl.obolibrary.org/obo/MONDO_0032710 https://identifiers.org/hgnc/7763 OMIM:618374 MONDO:OMIM https://omim.org/entry/601725
http://purl.obolibrary.org/obo/MONDO_0044724 https://identifiers.org/hgnc/23656 OMIM:617698 MONDO:OMIM https://omim.org/entry/607381

Additional details

Context: Tech meeting notes, 2024/06/05

Related

joeflack4 commented 3 weeks ago

@matentzn RE: filename. I think you said robot.tsv, which I've also seen recently, but I thought we were doing robot.template.tsv. Has that changed?

joeflack4 commented 3 weeks ago

@matentzn Just to clarify--you mentioned that we are aware that the prefixes and URI prefixes are in flux (e.g. MIM). But I think the determination was that we would keep the values the same? E.g. omim_disease_xref entries will stay as OMIM:12345, and the omim_gene field (ignored by robot) will stay as-is, etc?

twhetzel commented 3 weeks ago

@joeflack4 for the robot file, I think the filename should be the same format as before, but it should be a .tsv file instead of a .csv file.

matentzn commented 3 weeks ago

@matentzn Just to clarify--you mentioned that we are aware that the prefixes and URI prefixes are in flux (e.g. MIM). But I think the determination was that we would keep the values the same? E.g. omim_disease_xref entries will stay as OMIM:12345, and the omim_gene field (ignored by robot) will stay as-is, etc?

The world seems to be moving to "MIM" as a prefix. I am against such changes, but the the overwhelming majority is for it, so it should be on your radar somewhere - not in this issue though. you can leave everything as is!

joeflack4 commented 3 weeks ago

Yep, on my radar!:

joeflack4 commented 5 days ago

Removed myself as assignee, as my part is done.

Also, at the time I created this I didn't realize that these 2 were highly related / the same thing in other words, otherwise I might have not made this issue: