Closed twhetzel closed 5 months ago
I am a bit confused by these comments.
1) All terms excluded should have an exclusion reason. This exclusion code is a way to document "why" the term is excluded from Mondo. (Maybe it is already or will at a later time be included in some mapping files) 2) @twhetzel I think you could use a more specific exclusion code. For example: MONDO:excludeGroupingHeritability (see exclusion code document) 3) This is just a file update, so I don't think we need to do anything else.
Joe - I am here on this PR as a curator for information for Sabrina to review, but good for you to have looked at this too.
Joe - I am here on this PR as a curator for information for Sabrina to review, but good for you to have looked at this too.
@twhetzel Yes, feel free to overrule, but I intend to at least look at every issue and PR that comes through mondo-ingest
.
I can also do so mutedly for these types of PRs; I suppose I don't have to comment / add a formal reivew.
related to mondo #7437
Overview
TODO
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/
?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingest
on this branch (afterdocker pull obolibrary/odkfull:dev
), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?