search

monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

HGNC ROBOT template - build #564

Closed joeflack4 closed 5 months ago

joeflack4 commented 5 months ago

QC / build PR for:

twhetzel commented 5 months ago

If the result files are in #https://github.com/monarch-initiative/mondo-ingest/pull/559 then overall I think this Build is ok, but I do have questions on the ROBOT file created in that PR https://github.com/monarch-initiative/mondo-ingest/pull/559#issuecomment-2166586440. Those questions do not effect this feature branch Build review PR though.

Curious though, why do the "mondo-genes..." files not show up here? nvm

I looked at all the files in this branch and see them now and I think I understand Nico's comment that they don't show up here since they didn't change between feature branch and feature branch build. But how did other files change? I'm curious how the build is being run and branching strategy.

joeflack4 commented 5 months ago

Closing this PR, as it has built successfully and been approved.

It does say that Trish requested changes, but that is pertaining to:

A few comments and there is a design question in https://github.com/monarch-initiative/mondo-ingest/pull/559

I looked into that, and it looks like the questions were all addressed, so I'm closing this now.