monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

TEST Build for Issue-560 #567

Closed twhetzel closed 2 weeks ago

twhetzel commented 2 weeks ago

Resolves #ISSUE(s).

Overview

This is test build for Issue-560 run as sh run.sh make build-mondo-ingest -B

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

twhetzel commented 2 weeks ago

The SPARQL change in #560 does not fix everything, but could use some extra eyes so we make sure this is ready for curator work next week. I am trying these changes Nico mentioned.

The issue with the doid.sssom.tsv file was in this PR.

Update: Yep, looks like those changes are the way to go. I am still doing some checking, but will close this Test Build.