monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Add confidence fill conditional in lexmatch compare #581

Closed matentzn closed 1 week ago

matentzn commented 1 week ago

resolves #583

Overview

Currently the filter_redundant_rows() in the sssom-py package fails when:

  1. There is a confidence column and
  2. No single value is set / all values are nan

This needs a fix in the sssom-py package.

In the meantime, this is a workaround.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

Build PR:

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

Related

joeflack4 commented 1 week ago

Not needed. The PR in sssom-py https://github.com/mapping-commons/sssom-py/pull/548 should eliminate the need for this.

That is good to know! I'm actually surprised though that this PR wasn't automatically closed, as #582 includes it and has already been merged. I double checked to make sure that this commit was included there and it is.

In any case gonna close this now.