Fix ODK version to 1.5.2

matentzn commented 4 months ago

To reduce suprises in the future, I suggest we move to a system where the have to deliberately change the ODK version we work with.

Overview

This PR:

Fixes the version of ODK used for everyone running the pipeline to 1.5.2

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

[ ] Yes
[x] No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

[X] Yes
[ ] No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

[ ] Yes, requirements.txt.full was updated and an ODK issue submitted
[X] No

Were any other non-Python packages added?

[ ] Yes, Dockerfile updated and an ODK issue submitted
[x] No

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

[ ] Yes

twhetzel commented 4 months ago

NOTE: This should be changed to 1.5.2 next week

twhetzel commented 4 months ago

The test build for this change is at: https://github.com/monarch-initiative/mondo-ingest/pull/620

The test build ran without error, but took 4:59:04 to complete, which is ~1 hr longer than previous builds. Other details in the Mondo Ingest Build Stats file.

matentzn commented 4 months ago

The test build ran without error, but took 4:59:04 to complete, which is ~1 hr longer than previous builds. Other details in the Mondo Ingest Build Stats file.

Nothing in my mind would explain this, as you were using dev previously, which more or less corresponds to the 1.5.2 release.. Sorry I am not any help!

monarch-initiative / mondo-ingest