monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Bug fix: ICD11 "label not found" `RuntimeError` #634

Closed joeflack4 closed 3 months ago

joeflack4 commented 3 months ago

Overview

Fixed bug in the problematic xrefs pipeline where an error would be thrown if there was no ICD11 label. The problem was that (i) the SPARQL query only checked for labels on owl:Class, but not also rdfs:Description, and (ii) tmp/component-download-*.ow.owl was being used instead of components/*.owl.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

Build

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

twhetzel commented 3 months ago

I converted this to a Draft for now now so that does not accidentally get merged. I'll decide after 11am PT if this branch will be used at all and close as needed.

twhetzel commented 3 months ago

Closing since we decided to go with this PR https://github.com/monarch-initiative/mondo-ingest/pull/637