Synchronization: Synonyms - `synonym_type`

[joeflack4]

Merging into:

• 93

Overview

Synchronization: Synonyms - synonym_type

• Update: New feature 'synonym_type' column to synonym sync outputs. Contains a combination of Mondo types declared for mapped synonyms as well as those obtained from the source, either declared in the component, or inferred by logic, e.g. mondo#ABBREVIATION. Previous 'synonym_type' column renamed to 'synonym_type_mondo'.

Also synonym sync related:

• Bug fix: Dropped duplicate rows

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

• [ ] Yes
• [x] No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

• [ ] Yes
• [x] No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

• [ ] Yes, requirements.txt.full was updated and an ODK issue submitted
• [x] No

Were any other non-Python packages added?

• [ ] Yes, Dockerfile updated and an ODK issue submitted
• [x] No

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

• [ ] Yes

Additional information

• Google sheet

[joeflack4]

Reviewed with Trish and approved. We are merging this feature branch into another feature branch. There are still a couple outstanding issues brought up here, but those will be handled in:

• 93

[twhetzel]

Joe, we reviewed this PR however I did not officially approve the PR or see the final code updates. This is a bad working process to say someone approved a PR and merge it when it was not approved.

[twhetzel]

Generally looks good. I saw a note the files were re-generated, but still directly under reports vs. reports/sync-synonyms.

[joeflack4]

@twhetzel Oh, sorry Trish. I asked a couple times if I would merge this PR once I pushed these new changes, and it sounded like you gave verbal confirmation. You probably didn't think I meant it literally.

I'm fine w/ that, though. This is a feature --> feature, so the flow felt different to me, but in the future I'll be sure to follow the same process.

If you want, take a look at the commits I made, and if you add comments/requests on those diffs I will act on them.

reports/syncs-synonyms/ I have in my personal notes for next week, but I've just added a tracker comment; will reply there when done.