monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Synonyms getting dropped when making component #665

Closed joeflack4 closed 1 week ago

joeflack4 commented 1 week ago

[!warning] This PR entails:

  • 663

Needed to merge that, otherwise build was failing.

Resolves #656

Overview

Bug fix: Synonym drops. Synonyms with type OMO:0003012 were getting dropped because there was not an entry for this in properties.txt.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?

Build PR:

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?