search

monarch-initiative / mondo-ingest

Coordinating the mondo-ingest with external sources
https://monarch-initiative.github.io/mondo-ingest/
6 stars 3 forks source link

Should `mirror_signature-ncit.tsv` use component-download instead? #678

Open joeflack4 opened 1 month ago

joeflack4 commented 1 month ago

Overview

reports/mirror_signature-%.tsv uses component-download-%.owl as a prereq.

But the specific goal for NCIT, reports/mirror_signature-ncit.tsv, uses $(COMPONENTSDIR)/ncit.db as a prereq. That .db uses components/ncit.owl.

So it's not actually a mirror signature; it's a component signature. For example, the components goal for NCIT does remove -T $(TMPDIR)/ncit_relevant_signature.txt --select complement --select "classes individuals" --trim false \.

I'm not sure if this effectively has any ramifications.

Possible solutions

Could change $(COMPONENTSDIR)/ncit.db prereq to tmp/component-download-ncit.owl.db.