monarch-initiative / mondo

Mondo Disease Ontology
http://obofoundry.org/ontology/mondo
Creative Commons Attribution 4.0 International
229 stars 52 forks source link

proposal to more explicitly separate human and non-human diseases #3855

Closed nicolevasilevsky closed 1 year ago

nicolevasilevsky commented 2 years ago

Open question: Will we mirror the top level hierarchy for non-human diseases?

nicolevasilevsky commented 2 years ago

query is here: src/sparql/reports/non-human-diseases.sparql

matentzn commented 2 years ago

I have updated the query on master, check here for demo: https://api.triplydb.com/s/2t8_ot6Me

@LLTommy thanks a ton for fixing this query for us, the Mondo team says thanks.

@nicolevasilevsky @sabrinatoro

you should now be able to run:

MEMORY_GB=12 ./run.sh make report-tbd-query-non-human-diseases
nicolevasilevsky commented 2 years ago

The report is available here

matentzn commented 2 years ago

Unfortunately, this needs more action items.

From the meeting:

nicolevasilevsky commented 2 years ago

related:

From @jmcmurry on August 17, 2016 22:50

Related to https://github.com/monarch-initiative/monarch-disease-ontology/issues/59 for human diseases, we should be able to append taxon to animal diseases. This will be needed for downstream enhancements to site search. https://github.com/monarch-initiative/monarch-app/issues/1317

screen shot 2016-08-17 at 3 48 53 pm

Copied from original issue: monarch-initiative/monarch-disease-ontology-RETIRED#144 Then copied from old Mondo issue: https://github.com/monarch-initiative/mondo/issues/190

sabrinatoro commented 2 years ago

Proposal (should be discussed on a call):

Note: If users want a "human-specific" version of Mondo (maybe this is a slim that Mondo can offer), one would have to take the whole ontology and subtract the non-human diseases (ie, using the human taxon would not work as it would ignore the terms which were not tagged with a taxon).

nicolevasilevsky commented 2 years ago

The decision from the Curation call: Add ‘present in taxon’ annotations to animal diseases, where applicable

sabrinatoro commented 2 years ago

ROBOT merge template: sh run.sh make TEMPLATE_URL="https://docs.google.com/spreadsheets/d/e/2PACX-1vTH9cFh2xadQnAOMUk920g-nzyrjtw06OpzlErksSqNhJk7rFRCcPDE1K2fVzIlyI1g_0TOnt0n7osF/pub?gid=7444001&single=true&output=tsv" merge_template -B

sabrinatoro commented 2 years ago

PR in progress:

sabrinatoro commented 2 years ago

Discussion:

sabrinatoro commented 1 year ago

There might still be some improvements to be made, but this issue can be closed.