Closed nicolevasilevsky closed 1 year ago
query is here: src/sparql/reports/non-human-diseases.sparql
I have updated the query on master, check here for demo: https://api.triplydb.com/s/2t8_ot6Me
@LLTommy thanks a ton for fixing this query for us, the Mondo team says thanks.
@nicolevasilevsky @sabrinatoro
you should now be able to run:
MEMORY_GB=12 ./run.sh make report-tbd-query-non-human-diseases
The report is available here
Unfortunately, this needs more action items.
From the meeting:
related:
From @jmcmurry on August 17, 2016 22:50
Related to https://github.com/monarch-initiative/monarch-disease-ontology/issues/59 for human diseases, we should be able to append taxon to animal diseases. This will be needed for downstream enhancements to site search. https://github.com/monarch-initiative/monarch-app/issues/1317
Copied from original issue: monarch-initiative/monarch-disease-ontology-RETIRED#144 Then copied from old Mondo issue: https://github.com/monarch-initiative/mondo/issues/190
Proposal (should be discussed on a call):
[ ] all current terms associated with a human gene should be human-specific (add taxon-need to use the correct relation, not to self to review what this relation should be) TO DO:
[ ] add taxon for non-human diseases TO DO:
[ ] When diseases are found in multiple species (e.g. leukemia), these terms should be species agnostic, and species-specific terms should be created as children (e.g. human leukemia, feline leukemia). TO DO:
[ ] review the classification and make sure everything makes sense.
[ ] (future work, during maintenance of the ontology): we should review definitions and determine which one refers to human-specific structures or molecules, and either update the definition to make the term more general or species agnostic, or create a new species agnostic term
Note: If users want a "human-specific" version of Mondo (maybe this is a slim that Mondo can offer), one would have to take the whole ontology and subtract the non-human diseases (ie, using the human taxon would not work as it would ignore the terms which were not tagged with a taxon).
The decision from the Curation call: Add ‘present in taxon’ annotations to animal diseases, where applicable
ROBOT merge template: sh run.sh make TEMPLATE_URL="https://docs.google.com/spreadsheets/d/e/2PACX-1vTH9cFh2xadQnAOMUk920g-nzyrjtw06OpzlErksSqNhJk7rFRCcPDE1K2fVzIlyI1g_0TOnt0n7osF/pub?gid=7444001&single=true&output=tsv" merge_template -B
Discussion:
Comments from Chris (copied from Slack)
updated PR: #5397
There might still be some improvements to be made, but this issue can be closed.
Open question: Will we mirror the top level hierarchy for non-human diseases?
For every class under non-human disease, take superclass and make ortholog for that, eg 'Brown-Pearce carcinoma', need non-human carcinoma
[x] need to do sparql query ?D isa NHAD, ?D isa ?S, not ?S isa NHAD