Closed matentzn closed 7 months ago
@nicolevasilevsky maybe you have institutional knowledge of these terms. From what I can tell, these have "narrow synonyms" that should be "exact synonyms". I cannot find evidence why they are "narrow". Do you remember anything about these? Would you agree that these (and all the versions of these synonyms) should be "exact synonyms"? Thank you!
@nicolevasilevsky They were added as "narrow synonym" in this issue based on genemap. But I am still confused.
We intentionally changed deafness to hearing loss per this request: https://github.com/monarch-initiative/mondo/issues/551
and Chris suggested that deafness be a narrow synonym of hearing loss.
Thank you @nicolevasilevsky. In practice though, there are exact synonym though? I think having them as narrow synonyms is causing some issues (e.g. groups are using narrow synonyms as preferred labels). I'll bring this up on the call.
I don't think it's technically correct to make them exact synonyms because you can have mild hearing loss that is not deafness, see Heidi's comment: https://github.com/monarch-initiative/mondo/issues/551#issue-385440764
I think it would be better to ask ClinGen if we can move the preferred label to match the primary label. Heidi is from ClinGen.
@sabrinatoro I will link the this issue and issue #551 to the terms above, so we remember this conversation!
@courtneythaxton , could you please share some input on this issue? I sent you an email with a more detailed background and context. Thank you!
I think it might be good to go back to the Hearing Loss EPs/CDWG and ask them about the narrow to exact match. From the ticket #551 there does appear to be a difference in deafness (profound hearing loss) and "hearing loss", so there may be a need to create new nodes instead of synonyms.
I emailed Sabrina and offered our DNAC February call, as Heidi and the other ClinGen Disease Naming Advisory Committee (DNAC) members would be able to weigh in. This also is a call Ada attends :).
I had an email conversation with Heidi Rehm and Marina DiStefano. They confirmed that the term to use should be the "hearing loss" one (and not the "deafness" one).
In summary, the labels in the list above, and not the narrow synonyms, should be the "ClinGen_label" (FKA ClinGen_preferred).
@matentzn : Please let me know how I can help
Is this related to https://github.com/monarch-initiative/mondo/pull/7112
Should this be closed with https://github.com/monarch-initiative/mondo/pull/7227 now merged?
oh yes, can be closed!
After our meeting with ClinGen, I am trying to put together a Mondo subset for ClinGen which we can load into Monarch OLS, and which gives the ClinGen data engineers a way to render Mondo information with the ClinGen preferred labels.
While building my draft, I noticed that current 55 synonyms preferred by ClinGen are considered "narrow" in Mondo. My questions are the following: