monarch-initiative / mondo

Mondo Disease Ontology
http://obofoundry.org/ontology/mondo
Creative Commons Attribution 4.0 International
229 stars 52 forks source link

remove "mondo-with-equivalents" and "mondo-minimal" from release #7912

Open sabrinatoro opened 3 months ago

sabrinatoro commented 3 months ago

We announced the following: We plan to remove the following ontology variants from future releases (starting with the July release): mondo-with-equivalents ; mondo-minimal. If you use these ontology variants, please let us know as soon as possible!

We have not heard that these ontology variants are in used. We can go ahead and remove them.

plweller3 commented 1 month ago

Here at ClinGenm we've been using the mondo-with-equivs for years. We use it in several projects, you could say it is a critical source of data for us.

I saw no such announcement that this file was going away. What is it being replaced with? Is the json schema unchanged in the new file?

matentzn commented 1 month ago

@plweller3 first of all, big apologies for the issues this has caused you. We announced it on the mondo-users mailing list

https://groups.google.com/g/mondo-users/c/Q-xuJEvjPxI/m/bwmnd0dOAAAJ

and in our Outreach call

But we should have checked more specifically with you, @courtneythaxton and @larrybabb, sorry about that!

I suggest we follow a three part approach

  1. I will add the mondo-with-equivalents to the release now so they are there (for now).
  2. You and I set up a call and I will tell you the replacement options and how they differ (the schema is the same, one relation is changed).
  3. We see that we move ClinGen to the more modern file (it is really not much different, just removing a relationship we now deem obsolete).

What do you think?

matentzn commented 1 month ago

I have added the mondo-to-equivalents variants now back to the release as a one off, but it would be good to proceed to steps 2 and 3 as well.. :)

matentzn commented 1 month ago

After reviewing @plweller3 pipeline, I suggest we do this:

  1. We will wait for @plweller3 to confirm that everything still works as expected using mondo.json.
  2. Add a redirect for the mondo-with-equivalents file to the normal mondo (https://github.com/OBOFoundry/purl.obolibrary.org/pull/1002/files).
  3. Not reinstate the release artefact as proposed in #8051, and close that PR