monarch-initiative / mondo

Mondo Disease Ontology
http://obofoundry.org/ontology/mondo
Creative Commons Attribution 4.0 International
237 stars 53 forks source link

Unsatisfiable class in Mondo #8429

Open matentzn opened 2 days ago

matentzn commented 2 days ago

When refreshing the OMIM gene relations (#8108) we noticed the following unsat.

This will be fun to crack! QC fail: https://github.com/monarch-initiative/mondo/actions/runs/11962410332/job/33350758622

osteopetrosis, autosomal dominant 3 SubClassOf Nothing

paroxysmal nocturnal hemoglobinuria 1 SubClassOf Nothing

Ontologies used:

twhetzel commented 2 days ago

Only MONDO:0020848 remains as an issue. Due to a bug in the omim ingest pipeline and/or lack information in an omim file, a gene association was added to MONDO:0010438 saying it was germline, when it already had somatic.

twhetzel commented 2 days ago

Related to the QC check error (Unsatisfiable) for MONDO_0020848, Nico pointed this out:

Based on https://omim.org/entry/611497, MONDO:0012679 'autosomal recessive osteopetrosis 6' has a gene association with evidence from medgen that does not meet our criteria for disease defining gene associations (the phenotype label displayed in omim is prefixed with a special character, e.g. ?) we add from omim. However, other sources like ClinGen include both of these diseases caused by this gene.

@sabrinatoro can you advise how to resolve this issue?

twhetzel commented 2 days ago

I removed the gene association from MONDO:0012679 'autosomal recessive osteopetrosis 6' since this does not meet our rules for adding gene associations based on OMIM data and for now we need to move forward on the Tech side based on discussions with @matentzn. If this is not the right decision from a curation perspective, that needs to be addressed later.

matentzn commented 2 days ago

FWIW I agree with the change for now, here it is for reference:

https://github.com/monarch-initiative/mondo/commit/da20096d18ad980b78c65398ac60867fc3d506d3#diff-889e0a9ba62d62cc6ee7c5c9bead0075444d506253590ef0dcf4786904ac6768L288824