monarch-initiative / monochrom

Standardized identifiers and OWL classes for chromosomes and chromosomal parts across species
http://monarch-initiative.github.io/monochrom/
13 stars 2 forks source link

document how ETL and ODK build compose #21

Open cmungall opened 3 years ago

cmungall commented 3 years ago

it's a bit clunky

the top level Makefile has targets to do ETL

the Makefile in src/ontology is a standard odk one. chr-edit.owl is not generally edited, it is mostly an importer

note: if ucsc.owl changes, chr.owl does NOT get triggered automatically. I touch chr-edit.owl to trigger this.

matentzn commented 3 years ago

Touching should not be necessary.

https://github.com/monarch-initiative/monochrom/blob/c3ca6a3642e7ec24b2cd7b05118071d52b4befa3/src/ontology/Makefile#L427

As you can see, $(COMPONENTSDIR)/ucsc.owl is a dependency of the chr-full.owl, so the goal should be retriggered whenever ucsc.owl changes.

matentzn commented 3 years ago

We could simply trigger the odk release from the top level Makefile as well?

odk:
     cd src/ontology && make prepare_release