search

monarch-initiative / omim

Data ingest pipeline for OMIM.
7 stars 3 forks source link

Redundant?: `exactSynonym` copies of labels #131

Closed joeflack4 closed 1 month ago

joeflack4 commented 2 months ago

Overview

At some point, we started adding an oio:exactSynonym for the exact string of every rdfs:label, e.g.:

OMIM:100050 a owl:Class ;
    rdfs:label "aarskog syndrome, autosomal dominant" ;
    MONDO:exclusionReason MONDO:excludeTrait ;
    oboInOwl:hasExactSynonym "aarskog syndrome, autosomal dominant" .

However, this may now be redundant, since we started doing this for all sources in mondo-ingest in recent months.

Given this redundancy, should we stop doing this in OMIM?

twhetzel commented 1 month ago

Good catch! Sounds like adding the term label as an exact synonym could possibly be removed from the OMIM repo. However the current OMIM code and current Mondo Ingest code are not causing duplicate exact synonyms to be added to an OMIM class in the omim.owl component file in Mondo Ingest repo so it's fine to leave the omim repo code as-is for this item.