search

monarch-initiative / omim

Data ingest pipeline for OMIM.
7 stars 3 forks source link

Bugfix: Invalid OMIM refs showing up in output #69

Closed joeflack4 closed 1 year ago

joeflack4 commented 1 year ago

Updates

Misc
    - Update: parse_morbid_map(): Added currently unused `phenotype_mapping_key_meanings` with a comment explaining how to use it.

    Misc
    - Update: Comments
    - Update: Minor refactoring

Addresses

https://github.com/monarch-initiative/mondo-ingest/issues/98

joeflack4 commented 1 year ago

Analysis results

Will explain more in the issue, but here are some preliminary output from analysis which we can look over to investigate further: confusingMimNums.csv

joeflack4 commented 1 year ago

This will be ready to merge if we determine that nothing needs to be done. It contains some minor refactors / misc updates. But likely we will need to update/fix something. Just not clear exactly what that will be yet.

matentzn commented 1 year ago

No problem with the changes here, feel free to merge but don't close related issue yet.

joeflack4 commented 1 year ago

Sounds good. Will merge this and keep issue open.