Change python requirement to >=3.8

monarch-initiative / oncoexporter

Cancer data to GA4GH phenopacket

https://monarch-initiative.github.io/oncoexporter

MIT License

6 stars 1 forks source link

Change python requirement to >=3.8 #60

Closed justaddcoffee closed 6 months ago

justaddcoffee commented 6 months ago

to address #59

ielis commented 6 months ago

@justaddcoffee can you pls also fix the failing test? I think it should be fairly straightforward, just using importlib.resources.files, FWIW..

justaddcoffee commented 6 months ago

Yeah, I was just doing that. This is broken in develop evidently, and also dependencies in pyproject.toml are not in the correct format AFAICT

justaddcoffee commented 6 months ago

Looks like tests are broken for a few reasons (not just because importlib.resources.files is missing)

also broken in develop, so fixing this might belong in a separate PR

ielis commented 6 months ago

@justaddcoffee let me merge this for now. The issue with the Python requirement has been resolved. The rest of stuff indeed needs to be resolved in separate PRs/issues.

justaddcoffee commented 6 months ago

+1 okay