Resolve issues with `CdaDiseaseFactory` tests

monarch-initiative / oncoexporter

Cancer data to GA4GH phenopacket

https://monarch-initiative.github.io/oncoexporter

MIT License

6 stars 1 forks source link

Resolve issues with `CdaDiseaseFactory` tests #66

Closed ielis closed 5 months ago

ielis commented 6 months ago

The tests of CdaDiseaseFactory are failing due to incomplete code of the ICD-O -> NCIT conversion.

@pnrobinson the code looks like a WIP from your side. Can you please implement the conversion? Alternatively, we need to discuss the requirements.

pnrobinson commented 6 months ago

I will not be able to work on this the next few days, this is a full week. However, Justin implemented download code for a mapping file and I think we might be close - I can cede this issue for now if you can work on it.

ielis commented 6 months ago

Sounds good, I think I and Justin can take it over.