search

monarch-initiative / owlsim-v3

Ontology Based Profile Matching
16 stars 5 forks source link

Should MatcherModule move from services to core? #16

Closed cmungall closed 9 years ago

cmungall commented 9 years ago

We have KnowledgeBadeModule in owlsim.kb in core - should MatcherModuler also be in core? Presumably in owlsim.compute.matcher?

ccondit commented 9 years ago

This module is strictly for resolving short names to ProfileMatcher implementations - which I think only a REST client would want to do. Can move over to core if you think that non-REST clients would want this functionality.

ccondit commented 9 years ago

Renamed the module with https://github.com/cmungall/owlsim-v3/commit/0eddbc9faf368d868142a642563e02f4527d30ff to clarify the intent.

cmungall commented 9 years ago

use case I had in mind was a command line interface where the user can specify a shortname.

Historically I've always done this with a big case/if/then/else switch which feels inelegant, but not a big deal

ccondit commented 9 years ago

Oh I see. Sure - I'll refactor this into core then.