Unused code elements in NaiveBayesFixedWeightThreeStateProfileMatcher

monarch-initiative / owlsim-v3

Ontology Based Profile Matching

17 stars 5 forks source link

Unused code elements in NaiveBayesFixedWeightThreeStateProfileMatcher #50

Open drseb opened 7 years ago

drseb commented 7 years ago

The set nodesQfPu is initialized, but it seems that nothing get added to this set. It is later transformed to the Bitmap nodesQfPuBM which is used to determine some andCardinality and andNot.

This seems wrong to me. Can you clarify?

drseb commented 7 years ago

It also seems to me that the following is also unused:

EWAHCompressedBitmap queryNegatedNoTransitionBM = getQueryNegatedNoTransition(nodesQfBM);
EWAHCompressedBitmap queryNegatedWithTransitionBM = nodesQfBM.andNot(queryNegatedNoTransitionBM);

line 160

cmungall commented 7 years ago

I can clarify something is up here.

Will investigate...