monarch-initiative / owlsim-v3

Ontology Based Profile Matching
17 stars 5 forks source link

Parameter choice leading to '-Inf' in NaiveBayesFixedWeightThreeStateProfileMatcher #51

Open drseb opened 7 years ago

drseb commented 7 years ago

If prWeakTrueMiss is too small (right now it is 0.85), we are introducing -Inf in lines 335/336/338

int nQuHuPt = nodesQuPtBM.andNot(nodesHtBM).andNotCardinality(nodesHfBM);
double cprQuHuPt = Math.pow(prWeakTrueMiss,  nQuHuPt);

In my code, nQuHuPt in use with HPO becomes larger than 10,000. Then cprQuHuPt = Math.pow(0.85, 10000) is 0 and in line 338 we compute Math.log(cprQuHuPt).

Questions:

Any help greatly appreciated.