monarch-initiative / owlsim-v3

Ontology Based Profile Matching
16 stars 5 forks source link

Add paging to ontomatch service #69

Open cmungall opened 7 years ago

cmungall commented 7 years ago

The route '/ontolomatch/MP/HP' should return a set of best matches in MP for HP (note this is less than the full all-by-all table).

Currently this gives a gateway timeout. Paging should be added.

Also, we should have a version that works for a specific ID, @drseb would use this.

drseb commented 7 years ago

I would also be happy with the full all-by-all table. How could I obtain this?

julesjacobsen commented 7 years ago

You should be able to just use the API directly:

BMKnowledgeBase bmKnowledgeBase = BMKnowledgeBase.owlLoader()...createKnowledgeBase();
ClassMatcher classMatcher= new ClassMatcher(bmKnowledgeBase);
List<SimpleClassMatch> matches =  classMatcher.matchOntologies("HP", "MP");
jnguyenx commented 7 years ago

We had a look with Chris, it doesn't seem to be an issue with the returned data being too large. But the service takes too long to return anyway, Chris will take a look at that.

cmungall commented 7 years ago

OK, great. To summarize:

drseb commented 7 years ago

I am happy with using the API. I am not closing, because the ticket is about something else now.