search

monarch-initiative / phenio

An integrated ontology for Phenomics
https://monarch-initiative.github.io/phenio/
BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Add MAXO #88

Open caufieldjh opened 1 month ago

caufieldjh commented 1 month ago

Describe the desired behavior or enhancement

@kevinschaper requests addition of MAXO.

https://www.ebi.ac.uk/ols4/ontologies/maxo

Additional context

Note that MAXO has >20 imports, many of which are in PHENIO already, so this will need to be the base.

matentzn commented 1 week ago

I agree with this, we should do this soon. @kevinschaper are we thinking about importing MAXO annotations into Monarch KG at all?

kevinschaper commented 1 week ago

Yeah, in progress here: https://github.com/monarch-initiative/maxo-annotation-ingest

I was hoping to at least get an initial version of this ingest into the KG for the Nov release.

matentzn commented 1 week ago

I guess it would be good then to have MAXO in phenio so you can at least get the labels correctly, right?

kevinschaper commented 1 week ago

Yup! If I add the ingest ahead of having MAXO nodes in Phenio, the edges would end up getting dropped. I could technically create nodes from the IDs and labels in the MAXO annotations if I just want a node with a label and category on the other side of the association, but if we did that sort of nonsense we wouldn't be the ontology people! :smile:

It's not a hard requirement to get MAXO into Phenio in the next few days though, so if we get bumped until December, that's ok.

matentzn commented 1 week ago

@caufieldjh can you are shall i do it? either way fine by me!

caufieldjh commented 1 week ago

I'll take care of this. Building a version now with the most recent Upheno and Mondo, so if that works as expected then next step will be adding MAXO.