search

monarch-initiative / phenoCompare

Phenotype Compare
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Implement patient detail files, update all output files #12

Closed hannahblau closed 6 years ago

hannahblau commented 6 years ago

See issue #11, created patient detail output files. Checked in all updated output files including clustering results generated by R scripts.

hannahblau commented 6 years ago

@pnrobinson I revised several files to take account of Codacy's suggestions, the ones I thought were worthwhile. Codacy says it cannot analyze the pull request but I don't see why because it already analyzed it once before. Anyway, please review this code when you have a chance. Also remember that when the detailFiles branch gets merged into the develop branch, we need to give Leigh a new set of pointers to the results and clustering directories so she can locate the output files (which have not changed, they will just get moved to the develop branch).

hannahblau commented 6 years ago

@pnrobinson, I think the pull request to merge the detailFiles branch back into develop is now ready for your review. I fixed the error I found, and improved some of the stylistic issues that Codacy highlighted. I'm ignoring the repeated Codacy complaints about implicit package-private access on classes and methods. Thanks, Hannah