search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Adds JSHint to the bundle workflow. Fixes many, but not all, of the JSHint-discovered errors. There are still many to fix in js/*.js. #102

Closed DoctorBud closed 9 years ago

DoctorBud commented 9 years ago

Adds JSHint to the bundle workflow. Fixes many, but not all, of the JSHint-discovered errors. There are still many to fix in js/*.js.

yuanzhou commented 9 years ago

Hi Dan, I didn’t know you were about to add jshint and make those fixes before I made changes to the code early this morning. I replaced the foreignObject based tooptip with the stickytooltip and removed unused functions/variables, as well as renamed the render.js to tooltiprender.js to follow the CommonJS naming convention. These involved many code changes. By the time I saw your PR, I’ve already committed those changes and now I can’t auto merge your PR.

Do you mind if I just manually add jshint to phenogrid and try to fix those sloppy warnings later on? Since I’ll work on another HPO related thing that Harry assigned me last week.

yuanzhou commented 9 years ago

DoctorBud has rebased this PR, will auto merge soon.