search

monarch-initiative / phenogrid

The phenogrid widget
13 stars 14 forks source link

Minify phenogrid-bundle.js #120

Closed kshefchek closed 9 years ago

kshefchek commented 9 years ago

phenogrid-bundle.js takes about 1.5-2 seconds to load, would it be possible to minify the file?

yuanzhou commented 9 years ago

@kshefchek I'll do a minify before the release. Right now it's good to have that non-minified version for debugging purpose.

yuanzhou commented 9 years ago

@harryhoch Do you think I should do the minify for the release version? gulp-uglify is used for this purpose and I can simply add a pile call to do the JS minify. I can also add the css minify. I'll prob still use the same file name for the minified version without adding .min in the file name so we don't have to make changes in monarch-app.

harryhoch commented 9 years ago

sure. if you see no concerns, go for it

On Jul 27, 2015, at 09:08, yuanzhou notifications@github.com<mailto:notifications@github.com> wrote:

@harryhochhttps://github.com/harryhoch Do you think I should do the minify for the release version? gulp-uglify is used for this purpose and I add simply add a pile call to do the JS minify. I can also add the css minify.

Reply to this email directly or view it on GitHubhttps://github.com/monarch-initiative/phenogrid/issues/120#issuecomment-125199390.

yuanzhou commented 9 years ago

Added js and css minify.

phenogrid-bundle.js file size: 1160K -> 520K phenogrid-bundle.css file size: 51K -> 37K