Closed harryhoch closed 9 years ago
@harryhoch I tried to see how the output of unmatched phenotypes look like, but there's nothing showed up after I clicked that checkbox, and the Homo sapiens says there's no Unmatched phenotypes. Do I need to add some random phenotypes in the config to see this?
Yes, that’s probably worth a try.
On 27 Jul 2015, at 9:00 AM, yuanzhou notifications@github.com wrote:
@harryhoch I tried to see how the output of unmatched phenotypes look like, but there's nothing showed up after I clicked that checkbox, and the Homo sapiens says there's no Unmatched phenotypes. Do I need to add some random phenotypes in the config to see this?
— Reply to this email directly or view it on GitHub.
Harry Hochheiser University of Pittsburgh Department of Biomedical Informatics harryh@pitt.edu 412 648 9300
Possible solution for the refactoring unmatched list that Joe and I talked about:
note: if we add these to grid, they will be sorted by frequency of which the will appear at the bottom of the list
how does #2 differ from what we have now?
the toggle is the same, but what we are proposing it to just keep unmatched within the grid verse at the bottom of the screen.
at the bottom. They could become cumbersome in the grid
ok, no problem
Unmatched phenotypes is working now.
serverURL
instead of the local browser base URL for each link, also unmatchedPhenotypes
array._buildUnmatchedPhenotypeDisplay()
from _createYLables()
into _addPhenogridControls()
since it's inside the phenogrid control containerNotes:
Further debugging with Mike showed us that the phenotype label is not in the unmatchedPhenotypes
array. But when embed phenogrid into monarch-app, the disease page returns the phenotype_list
based that that disease, and the returned array contains label of each phenotype. That's why it worked with monarch-app, but didn't work as a standalone app.
@yuanzhou - please look into the unmatched phenotypes and see if it is working correctly.